Strip Addon Project URLs #1981
Closed
Strip Addon Project URLs #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitespace causes problems so strip, as gramps does for some other input fields
Nick-Hall
reviewed
Feb 17, 2025
| @@ -431,6 +431,9 @@ def __init__(self, dbstate, uistate, track): | |||
| hbox.pack_start(self.addon_combo, False, False, 0) | |||
|
|
|||
| self.projects = config.get("behavior.addons-projects") | |||
| # strip the incoming URLs to avoid any leading or trailing whitespace | |||
| for project in self.projects: | |||
| project[1] = project[1].strip() | |||
There was a problem hiding this comment.
I would prefer to ensure that urls were stripped of whitespace before storing in the preferences.
There was a problem hiding this comment.
With the current approach all URLs are stripped on the way in to gramps (either from the preference - this code, or when a new URL is entered by the user - the other change in this PR). Therefore I don't think there is any need to strip when storing in the preferences. As a by product the URLs are whitespace free during the lifetime of the addon manager dialog.
Stripping URLs when reading the preference covers the scenario of an upgraded 5.2 preference file already containing whitespace on the URLs.
|
Closed in favour of PR #1991. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leading and trailing whitespaces in the URL causes problems as discussed here
Call strip on any new URLs enter by the user.
For additional safety, call strip when loading already configured projects.