feat(lsp): Allow goto definition on include statements
#2027
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
marcusroberts,
ospencer,
peblair and
phated
as code owners
Member
|
Is there not a valid location for the included module available from the environment? |
Member
Author
I looked for one but couldn't find it. |
spotandjake
force-pushed
the
spotandjake-goto-include
branch
from
bfcb543 to
b9c1878
Compare
| let newenv = Env.include_module(mod_name, sod, env); | ||
|
|
||
| let od = {tinc_path: path, tinc_loc: sod.pinc_loc}; | ||
| let mod_file = |
Member
There was a problem hiding this comment.
Just one question before I press approve. When would the module file end in .wasm ?
Member
|
I spent some time looking into this and I don't see an easy path forward right now. The method you're using right now to get the source is a bit fragile because it's looking at where the object file is rather than where the source is. We may want to just add a field to the objects that points to the source so we can read it from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr allows for you to use
go to definitiononIncludestatements.Work for: #1624
Note:
As we did not reference the source module from the include statement before this change required adding that
attr, The best way I could find to do it was when we got the module name. An alternative approach would have been to pass thesod.pinc_path.txton ininclude_modulebut this would lead to inconsistencies with theincludeformat.