Upgraded to Grails 7. New github actions. Removed travis builder. Cleanup #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrei
reviewed
Aug 25, 2025
matrei
reviewed
Aug 25, 2025
|
@matrei Thank you for your thorough review 🙂 |
matrei
reviewed
Aug 26, 2025
Comment on lines
+42
to
+48
| run: ./gradlew docs | ||
| - name: "📤 Publish Snapshot Documentation to Github Pages" | ||
| uses: apache/grails-github-actions/deploy-github-pages@asf | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GRADLE_PUBLISH_RELEASE: 'false' | ||
| SOURCE_FOLDER: build/docs |
matrei
reviewed
Aug 26, 2025
Comment on lines
+121
to
+131
| - name: "📖 Generate Documentation" | ||
| if: ${{ env.DOCUMENTATION != 'false' }} | ||
| run: ./gradlew docs | ||
| - name: "📤 Publish Documentation to Github Pages" | ||
| if: ${{ env.DOCUMENTATION != 'false' }} | ||
| uses: apache/grails-github-actions/deploy-github-pages@asf | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GRADLE_PUBLISH_RELEASE: 'true' | ||
| SOURCE_FOLDER: build/docs | ||
| VERSION: ${{ needs.publish.outputs.release_version }} |
matrei
reviewed
Aug 26, 2025
There was a problem hiding this comment.
My pleasure @sbglasius! There still seems to be unresolved comments from my previous review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-pilot summary:
This pull request modernizes the project's build, CI/CD, and release infrastructure by replacing legacy Travis CI configuration with GitHub Actions workflows, updating dependency management, and aligning the project with current Grails and Java versions. The changes also introduce automated release note generation and improve reproducible build practices.
Continuous Integration and Release Automation
gradle.yml), release publishing (release.yml), and automated release note drafting (release-notes.yml), replacing the old Travis CI setup. This includes matrix builds for Java 17 and 21, snapshot publishing, documentation deployment, and artifact signing for reproducible releases. [1] [2] [3]Dependency and Build Configuration Updates
gradle.propertiesto use Grails 7.x and Java 17, enabled Gradle daemon and parallel builds, and increased JVM memory.buildSrc/build.gradleto support custom Gradle plugins and Grails BOM-based dependency management.Release Management Improvements
Documentation and Licensing
LICENSEfile.Legacy Cleanup
.travis.ymlfile, fully migrating CI/CD to GitHub Actions.