-
Notifications
You must be signed in to change notification settings - Fork 22
Regenerate client with fixed swagger #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate client with fixed swagger #20
Conversation
|
Hey @wkozlik , just tagging you here for visibility. |
|
Edit: raised a fix, and manually edited what will be included in the fix here. Turns out this is being affected by a bug in swagger-codegen, looking into a fix. |
wkozlik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. This looks great!
|
Thanks for reviewing @wkozlik ! Would you be able to tag a version when you get a chance as well? I have it as |
|
Thank you for this fix. It is looking great. I need to update the build step, to be able to merge this PR. |
|
@wkozlik anything I can help contribute to? |
|
I am sorry for the delay. We should be okay now. Could you resolve merge conflicts? |
|
No worries! just resolved, should be good to go |
This PR regenerates the client with an adapted generator based off of #15.
The current client is not up to date, and has old bugs that were fixed in the past year or so.
This PR also moves to go module using name
module github.com/grafeas/client-go, and moves away from keeping the version in the generated directory.Now we generate into two paths,
grafeasandprojectsfor the two different swagger files. Updating documentation included in README.md