Skip to content

Conversation

@aethanol
Copy link

@aethanol aethanol commented Feb 28, 2023

This PR regenerates the client with an adapted generator based off of #15.
The current client is not up to date, and has old bugs that were fixed in the past year or so.
This PR also moves to go module using name module github.com/grafeas/client-go, and moves away from keeping the version in the generated directory.
Now we generate into two paths, grafeas and projects for the two different swagger files. Updating documentation included in README.md

@aethanol
Copy link
Author

Hey @wkozlik , just tagging you here for visibility.

@aethanol
Copy link
Author

aethanol commented Mar 1, 2023

Edit: raised a fix, and manually edited what will be included in the fix here.
swagger-api/swagger-codegen#12076

Turns out this is being affected by a bug in swagger-codegen, looking into a fix.

Copy link
Contributor

@wkozlik wkozlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. This looks great!

@aethanol
Copy link
Author

aethanol commented Mar 2, 2023

Thanks for reviewing @wkozlik ! Would you be able to tag a version when you get a chance as well? I have it as 1.0.0 in the config.go.json file.
Otherwise this should be good to go. I'll plan on updating this PR whenever the swagger-codegen change gets merged.

@wkozlik
Copy link
Contributor

wkozlik commented Mar 7, 2023

Thank you for this fix. It is looking great. I need to update the build step, to be able to merge this PR.

@aethanol
Copy link
Author

@wkozlik anything I can help contribute to?

@wkozlik
Copy link
Contributor

wkozlik commented Mar 23, 2023

I am sorry for the delay. We should be okay now. Could you resolve merge conflicts?

@aethanol
Copy link
Author

No worries! just resolved, should be good to go

@wkozlik wkozlik merged commit fb48b81 into grafeas:master Mar 23, 2023
@aethanol aethanol deleted the regenerate-openapi-fixed branch March 24, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants