-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use k6foundry for building #124
Conversation
8a40fec
to
6efad77
Compare
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
6efad77
to
f7b6ec9
Compare
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exit code on error should be fixed (it should be 1 as before). Probably a lot of automation depends on this.
There is a problem with building private extensions. The following should work (it worked with the old xk6), but it doesn't:
export GOPRIVATE=github.com/grafana/hackathon-2024-12-weaver-spiders
xk6 build --with github.com/grafana/hackathon-2024-12-weaver-spiders
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replace build logic with k6foundry library. Also, refactors the build argument parsing logic to facilitate testing.
This change required upgrading to golang
1.22
(required byk6foundry
).Fixes #112