Include insecure option and tls options when STS S3 token is enabled #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <[email protected]>
rubenvp8510
force-pushed
the
render_tls_options_sts
branch
from
9454df7 to
e5ecce1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 58.60% 58.60%
=======================================
Files 113 113
Lines 10160 10160
=======================================
Hits 5954 5954
Misses 3900 3900
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@IshwarKanse Could you please help me to test this? Thanks |
|
@rubenvp8510 Sure, I'll check and let you know. |
|
@rubenvp8510 Verified the bug fix, we are good to merge the PR :) |
Co-authored-by: Andreas Gerstmayr <[email protected]>
Thank you! |
andreasgerstmayr
approved these changes
Feb 7, 2025
Signed-off-by: Ruben Vargas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.