feat(ui): add ShareTimeRangeButton component #156
Conversation
There was a problem hiding this comment.
Left some comments bellow - mainly related to relative imports that should be now imported in grafana/ui, as these are not going to be accessible in this package anymore.
I am also wondering, if you've tried to build and test this locally because currently it throws a lot of errors
| import { useStyles2 } from '../../themes'; | ||
| import { copyText } from '../../utils/clipboard'; | ||
| import { t, Trans } from '../../utils/i18n'; | ||
| import { absoluteTimeRangeURL } from '../../utils/time'; | ||
| import { Button, ButtonGroup, type ButtonProps } from '../Button'; | ||
| import { ClipboardButton } from '../ClipboardButton/ClipboardButton'; | ||
| import { Dropdown } from '../Dropdown/Dropdown'; | ||
| import { Menu } from '../Menu/Menu'; | ||
| import { type MenuItemElement } from '../Menu/MenuItem'; |
There was a problem hiding this comment.
These all are no longer accessible through relative path and you need to import them from @grafana/ui
| @@ -0,0 +1,110 @@ | |||
| import { css } from '@emotion/css'; | |||
| import { useRef, useState } from 'react'; | |||
There was a problem hiding this comment.
| import { useRef, useState } from 'react'; | |
| import React, { useRef, useState } from 'react'; |
|
hey @ivanahuckova sorry I have converted this to a draft. I have not tried building/running it in this repo, I just moved this over from a thanks for taking a look 🤝 |
moving from grafana/grafana#100940 to here
What is this feature?
this feature adds a reusable "Share Time Range" button component to the grafana-ui package. this button shares the current URL with the
fromandtoquery parameters changed from relative time to absolute time.Why do we need this feature?
many plugins and other areas of Grafana leverage relative time for basic use, but when it comes to sharing that view with others, copying the URL falls short since the link effectively expires after a a short time.
this button provides a universal way of sharing a snapshot of time easily and across many areas of Grafana.
Who is this feature for?
developers who want to make it easier to URLs in their plugins
Special notes for your reviewer:
Please check that: