Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xk6 topic not required for internal extensions #91

Merged
merged 1 commit into from
Oct 11, 2024
Merged

xk6 topic not required for internal extensions #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions cmd/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,19 @@ func validateWithLinter(registry k6registry.Registry) error {
}

func hasTopic(ext k6registry.Extension) bool {
found := false

for _, topic := range ext.Repo.Topics {
if topic == "xk6" {
found = true
return true
}
}

break
for _, product := range ext.Products {
if product == k6registry.ProductOSS { // for oss, topic is required
return false
}
}

return found
return true // for non oss, topic isn't required
}

func lintExtension(ext k6registry.Extension) (bool, []string) {
Expand Down
9 changes: 9 additions & 0 deletions releases/v0.1.32.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
k6registry `v0.1.32` is here 🎉!

This is an internal maintenance release.

**xk6 topic not required for internal extensions**

The internal linter previously expected the `xk6` topic to be set on the extensions repository. In the case of internal (albeit public) extensions, it would not be a good idea to use the `xk6` topic, because that would cause them to appear in the GitHub topic search.

The internal linter now does not expect the xk6 topic to be set for extensions that do not have `oss` in their `products` property. That is, in the case of extensions that cannot be used in Grafana k6, the use of the `xk6` topic is not required.
Loading