Workflow: Clone and build grafana #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
changed the title
andresmgot
requested review from
wbrowne,
marefr and
oshirohugo
and removed request for
a team
xnyo
approved these changes
Nov 17, 2023
| @@ -45,7 +45,7 @@ require ( | |||
| go.opentelemetry.io/otel/sdk v1.20.0 | |||
| go.opentelemetry.io/otel/trace v1.20.0 | |||
| golang.org/x/net v0.17.0 | |||
| golang.org/x/oauth2 v0.11.0 | |||
| golang.org/x/oauth2 v0.12.0 | |||
There was a problem hiding this comment.
nope, this was just for triggering the workflow (it only executes if there are changes to go.mod) but thought of keeping it so we can move the updates and see this being triggered in other PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The most common cause to reject a PR that updates go.mod dependencies is that Grafana would not compile with the update in the SDK due to incompatible changes. This PR adds a GitHub workflow that checks if a given PR is compatible with Grafana.
It's just informative, not blocking the PR.
Which issue(s) this PR fixes:
Part of #417
Special notes for your reviewer: