Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws-sdk-go-v2 credentials provider (session wrapper) #185

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

njvrzm
Copy link
Contributor

@njvrzm njvrzm commented Dec 4, 2024

This extracts some code from the Redshift V2 migration for use in future migrations. It should be considered experimental for now, but it does work.

@njvrzm njvrzm self-assigned this Dec 4, 2024
@njvrzm njvrzm requested a review from a team as a code owner December 4, 2024 16:07
@njvrzm njvrzm requested review from kevinwcyu, nmarrs and iwysiu and removed request for nmarrs December 4, 2024 16:07
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for getting the redshift poc in, but if I'm correct this is still dependent on the aws-sdk v1, right?

@njvrzm
Copy link
Contributor Author

njvrzm commented Dec 5, 2024

Yes, definitely - it's a temporary workaround to enable us to migrate the individual datasources' direct use of the AWS SDK to v2 independely from migrating our auth functionality here.

@njvrzm njvrzm force-pushed the njvrzm/v2-credentials-provider branch from 3ab5861 to 273f671 Compare December 5, 2024 11:57
@njvrzm njvrzm merged commit 03f6752 into main Dec 17, 2024
3 checks passed
@njvrzm njvrzm deleted the njvrzm/v2-credentials-provider branch December 17, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants