Skip to content

Commit

Permalink
chore(release): make releases with with github actions user
Browse files Browse the repository at this point in the history
Since the GitHub Actions user creates our release tag and release, it
doesn't trigger the actual build. But we can do the same thing we do for
the release PR: create the release in draft mode, and then a human
publishes. Since a human takes that action, it should trigger the build.

Also, don't include the project name in the tag names. It's not required
since this isn't a monorepo.
  • Loading branch information
iainlane committed Nov 8, 2024
1 parent a684c9a commit 2ed6e89
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .release-please.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@
"type": "refactor"
}
],
"draft": true,
"draft-pull-request": true,
"include-component-in-tag": false,
"include-v-in-tag": true,
"packages": {
".": {
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ We use [`release-please`][release-please] to create releases. This will maintain
a draft pull request with the changes needed to bump the version and update the
changelog, updated with the changes since the last release.

Releasing should be as simple as merging that pull request. Check that a GitHub
Releasing should be as simple as undrafting and merging that pull request, then
double-checking the created release and publishing it. Check that a GitHub
release, a tag, and the Docker releases were created.

### Use conventional commit messages
Expand Down

0 comments on commit 2ed6e89

Please sign in to comment.