Support log volume for SQL editor #1472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json
adamyeats
requested changes
Dec 15, 2025
Contributor
adamyeats
left a comment
adamyeats
left a comment
There was a problem hiding this comment.
Code LGTM, but needs tests (unit or E2E).
aangelisc
force-pushed
the
andreas/logs-volume-update
branch
from
6b73cbb to
2c57b0c
Compare
Contributor
Author
|
Closing in favour of #1475 |
github-project-automation
bot
moved this from Needs Review
to Done
in Partner Datasources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL editor implementation in ClickHouse makes supporting the log volumes query challenging. The query issued for log volumes is dependant on identifying the time column which is not straightforward for raw SQL queries.
The logs panel supports a fallback function for calculating log volumes for data sources that do not inherently support the log volumes query. As ClickHouse does support the necessary query we couldn't directly use this. grafana/grafana#115348 has made the execution of this function more flexible, allowing the data source to determine if it supports the logs volume query by inspecting query attributes.
We now take advantage of this to identify if any of the queries make use of the SQL editor. If they do, we do not indicate that we support the logs volume query. In this case, the fallback function will be used instead.
Fixes #1364