Clarify that blocks need to be enabled in the configured_collectors argument #4806
+153
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
💻 Deploy preview available (Clarify that blocks need to be enabled in the configured_collectors argument): |
clayton-cornell
added
type/docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the documentation for the prometheus.exporter.windows component by fixing formatting inconsistencies, correcting typos, clarifying language, and adding a comprehensive configuration example.
- Standardizes Markdown table formatting across all tables
- Fixes spelling errors and improves grammar for clarity
- Adds a new advanced example demonstrating how to enable and configure multiple collectors
| | Name | Type | Description | Default | Required | | ||
| | --------------------------- | -------- | ------------------------------------------- | -------- | -------- | | ||
| | `counter_version` | `int` | Version of the process collector to use. | `0` | no | | ||
| | `enable_iis_worker_process` | `bool` | Enable IIS worker process name queries. | `false` | no | |
There was a problem hiding this comment.
Type changed from string to bool for enable_iis_worker_process. Verify this accurately reflects the actual API, as boolean is more appropriate for an enable/disable flag than string.
docs/sources/reference/components/prometheus/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
…er.windows.md Co-authored-by: Copilot <[email protected]>
…er.windows.md Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that blocks need to be enabled in the
configured_collectorsargument. Add an example showing how this is done. Clean up text content to reduce Vale errors and align better with Grafana styles. Fix a type error (string vs bool).Fixes https://github.com/grafana/support-escalations/issues/18939