Skip to content

CTS for linear_indexing language feature#4595

Merged
alan-baker merged 1 commit intogpuweb:mainfrom
alan-baker:linear-indexing
Mar 10, 2026
Merged

CTS for linear_indexing language feature#4595
alan-baker merged 1 commit intogpuweb:mainfrom
alan-baker:linear-indexing

Conversation

@alan-baker
Copy link
Contributor

@alan-baker alan-baker commented Feb 16, 2026

Tests for gpuweb/gpuweb#5554

  • Execution tests for new builtins
  • Validation tests for new builtins
  • Validation tests for api dispatch

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

github-actions bot commented Feb 16, 2026

Results for build job (at 1ecaadc):

+webgpu:api,validation,dispatch:dispatch,linear_indexing_range:* - 2 cases, 4 subcases (~2/case)
+webgpu:api,validation,dispatch:dispatchIndirect,linear_indexing_range:* - 2 cases, 4 subcases (~2/case)
-webgpu:shader,validation,parse,requires:wgsl_matches_api:* - 9 cases, 9 subcases (~1/case)
+webgpu:shader,validation,parse,requires:wgsl_matches_api:* - 10 cases, 10 subcases (~1/case)
-webgpu:shader,validation,shader_io,builtins:stage_inout:* - 464 cases, 464 subcases (~1/case)
-webgpu:shader,validation,shader_io,builtins:type:* - 58 cases, 2320 subcases (~40/case)
+webgpu:shader,validation,shader_io,builtins:stage_inout:* - 496 cases, 496 subcases (~1/case)
+webgpu:shader,validation,shader_io,builtins:type:* - 62 cases, 2480 subcases (~40/case)
-webgpu:shader,validation,shader_io,builtins:reuse_builtin_name:* - 145 cases, 145 subcases (~1/case)
+webgpu:shader,validation,shader_io,builtins:reuse_builtin_name:* - 155 cases, 155 subcases (~1/case)
-webgpu:shader,validation,shader_io,invariant:valid_only_with_vertex_position_builtin:* - 58 cases, 58 subcases (~1/case)
+webgpu:shader,validation,shader_io,invariant:valid_only_with_vertex_position_builtin:* - 62 cases, 62 subcases (~1/case)
-TOTAL: 280595 cases, 2321594 subcases
+TOTAL: 280650 cases, 2321809 subcases

@alan-baker alan-baker marked this pull request as ready for review February 23, 2026 20:17
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really review thoroughly because it seems it's been plenty reviewed. Just one note

* Execution tests for new builtins
* Validation tests for new builtins
* Api dispatch validation tests
@alan-baker alan-baker enabled auto-merge (squash) March 10, 2026 21:41
@alan-baker alan-baker merged commit 4cafebf into gpuweb:main Mar 10, 2026
1 check passed
@alan-baker alan-baker deleted the linear-indexing branch March 10, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants