Skip to content

Conversation

andyleiserson
Copy link
Contributor

Adds the TODO coverage items to the copy_within_same_texture test:

  • Copying between different MIP levels of a 2D texture is allowed.
  • Copying from a 1D or 3D texture to itself is never possible because there is only one subresource.

Passes in Chrome and Safari, and should pass in Firefox soon.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@andyleiserson andyleiserson force-pushed the copy-within-same-texture branch from 76efa04 to c2195bb Compare July 22, 2025 01:36
@andyleiserson andyleiserson force-pushed the copy-within-same-texture branch from c2195bb to 7d78657 Compare July 22, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant