Fix server creds #909
Merged
Fix server creds #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Donnie Adams <[email protected]>
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42 and
g-linville
iwilltry42
previously approved these changes
Nov 21, 2024
StrongMonkey
previously approved these changes
Nov 21, 2024
njhale
previously approved these changes
Nov 21, 2024
When running in SDK server mode and using the file cred store, we must reload the credentials in the file each time. Typically, these credentials will be added via a tool call, which would invalidate the credentials held in memory. Signed-off-by: Donnie Adams <[email protected]>
thedadams
dismissed stale reviews from njhale, StrongMonkey, and iwilltry42
via
c91ac71
thedadams
force-pushed
the
fix-server-creds
branch
from
90904b2 to
c91ac71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does two related things:
reload the credentials in the file each time. Typically, these
credentials will be added via a tool call, which would invalidate the
credentials held in memory.