chore: include gptscript-credential-helpers in packaging #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-linville
requested review from
thedadams,
njhale,
StrongMonkey,
iwilltry42 and
tylerslaton
thedadams
reviewed
Apr 24, 2024
| mkdir -p "$BINARY_DIR" | ||
| cd "$BINARY_DIR" | ||
|
|
||
| wget -O gptscript-credential-osxkeychain "https://github.com/gptscript-ai/gptscript-credential-helpers/releases/download/${GPTSCRIPT_CRED_HELPERS_VERSION}/gptscript-credential-osxkeychain" |
There was a problem hiding this comment.
I actually like wget a lot just for downloading files, lol. I can never remember the arguments I need to give to curl. 🤷♂️
StrongMonkey
approved these changes
Apr 24, 2024
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
package-cred-helpers
branch
from
e62b51c to
38df29b
Compare
thedadams
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last step for packaging the GPTScript credential helpers, which are small CLI programs (forked from the docker-credential-helpers repo) that gptscript uses to interact with OS keystores. The source for this is at github.com/gptscript-ai/gptscript-credential-helpers
I recently revamped and cleaned up the credential helper repo and created its first GitHub release, v0.1.0. I also combined the amd64 and arm64 darwin binaries into a single universal binary using github.com/g-linville/makefat, my fork of the tool github.com/randall77/makefat. (We can move this fork to gptscript-ai if we want. I basically just added CI and a goreleaser config for it, and set up reproducible builds.)
These changes add hooks to the goreleaser file to download the compiled binaries for gptscript-credential-osxkeychain and gptscript-credential-wincred.exe from the v0.1.0 release in the credential helpers repo. Then, the programs get copied into the correct release folder for their corresponding OS+arch.
The trouble with this is that I can't fully test to make sure that the changes are picked up and working in Homebrew and Winget until this is in. Since Winget is just uploading the archive that contains the binaries, I think it should work. And I added another command to the Homebrew formula that should cause it to install the osxkeychain helper alongside gptscript itself.