Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select by grn #51

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Select by grn #51

merged 8 commits into from
Aug 9, 2024

Conversation

gph82
Copy link
Owner

@gph82 gph82 commented Aug 8, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.

Project coverage is 96.52%. Comparing base (1f17f47) to head (739074e).

Files Patch % Lines
mdciao/contacts/contacts.py 33.33% 8 Missing ⚠️
mdciao/plots/plots.py 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   96.57%   96.52%   -0.06%     
==========================================
  Files          52       52              
  Lines       13712    13764      +52     
==========================================
+ Hits        13243    13286      +43     
- Misses        469      478       +9     
Flag Coverage Δ
unittests 96.52% <86.15%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gph82 added 6 commits August 9, 2024 15:52
…rror for missing consensus labels if residue descriptor has a "."
…sensus' and 'try_consensus'

Although this method is poised to be deprecated, it's the best place to implement this RN
…t_by=consensus.

Making plots nomenclature-aware introduces a new dependency plots -> nomenclature

Also, refactor _metric_types_for_sorting->_schemes_for_sorting
…hen saving (else you can't both save AND have the figure shown)
@gph82 gph82 merged commit aff1bdd into master Aug 9, 2024
12 of 14 checks passed
@gph82 gph82 deleted the select_by_GRN branch August 9, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants