Removed method StreamPlayer.getPositionByte() #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method was used in a unit test, as a means to
test the StreamPlayer.seekTo() method, but it never
worked. The StreamPlayer.getPositionByte() didn't seem
to work.
There are no other callers of getPositionByte() method in this codebase.
It is not used by XR3Player. It seems safe to remove it.
If the method really worked (which I doubt), then this is a
non-backwards-compatible change.
This change is a part of an effort to make all unit tests pass, by either updating the production code, the tests, or remove the failing tests.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Has This Been Tested?
Checklist: