Fix plot missing time info #16 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plot function was sometimes messing with time info. This is caused by the times_inf() functions which add desat times and remove duplicated ones. Then if desat time is the same as the depth time, only one is shown. Also options where either time_print or deco_print. Now both can be added to the plot. If both are present, the text is bold but this is a minor issue. Plot check still require human check with the dev/graphic_vignette, which is difficult and explain why all the graphic script is not tested. Resolves: #16 gowachin [email protected] 24/03/2022
Issue was detected by a test for rm_secu(). In case of secu removal with only the secu deco stop, time value is now NA and I used to convert all NA from double to logical with type.convert(). It seems that this function now require a new argument. gowachin [email protected] 24/03/2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plot function was sometimes messing with time info.
This is caused by the times_inf() functions which add desat times
and remove duplicated ones. Then if desat time is the same as the
depth time, only one is shown.
Also options where either time_print or deco_print. Now both can be
added to the plot. If both are present, the text is bold but this is a
minor issue.
Plot check still require human check with the dev/graphic_vignette,
which is difficult and explain why all the graphic script is not tested.
Resolves: #16