Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot is sometimes missing information. #16

Open
gowachin opened this issue Mar 23, 2022 · 2 comments · Fixed by #17
Open

Plot is sometimes missing information. #16

gowachin opened this issue Mar 23, 2022 · 2 comments · Fixed by #17
Assignees
Labels
bug Something isn't working

Comments

@gowachin
Copy link
Owner

The text for deco stop is sometimes missing.

Ex : Missing 20' time mark above the second deco stop. A second dive with 19' depth time work.

d1 <- dive(40, 10)
d2 <- dive(30, 20)
ds <- ndive(d1, d2, inter = 60)
plot(ds)
summary(ds$dive2) # deco time is 20min

Should work like :

d2 <- dive(30, 19)
ds <- ndive(d1, d2, inter = 60)
plot(ds)
summary(ds$dive2) # deco time is 20min

It also could be nice to improve horizontal spacing for inter time and maj time.

@gowachin gowachin added the bug Something isn't working label Mar 23, 2022
@gowachin gowachin self-assigned this Mar 23, 2022
@gowachin
Copy link
Owner Author

gowachin commented Mar 23, 2022

Short investigation : plot deco time depend on hold desat object structure, and time can appear thanks to times_inf function and time_print option. This specific example is not working because of duplicated time period at depth and deco stop !

# additionnal example for duplicate effect
d1 <- dive(40, 10)
d2 <- dive(15, 3) # deco stop will be 3 and time at depth is 3...so only one exist !
ds <- ndive(d1, d2, inter = 60)
plot(ds)

deco_print option for the plot.dive() function is not working.

Need to rethink this part of plot !

gowachin added a commit that referenced this issue Mar 24, 2022
Plot function was sometimes messing with time info.
This is caused by the times_inf() functions which add desat times
and remove duplicated ones. Then if desat time is the same as the
depth time, only one is shown.
Also options where either time_print or deco_print. Now both can be
added to the plot. If both are present, the text is bold but this is a
minor issue.

Plot check still require human check with the dev/graphic_vignette,
which is difficult and explain why all the graphic script is not tested.

Resolves: #16

gowachin
[email protected]
24/03/2022
gowachin added a commit that referenced this issue Mar 24, 2022
@gowachin
Copy link
Owner Author

Wrong plot for dive conso for specifi values. Ascent time is merged with bottom time.

library(DiveR)
dive <- dive(50, 10, secu = FALSE)
tank <- tank(15, 210, rules = list(rules = c(80, 50), sys = "bar"))
conso <- conso(dive, tank, cons = 26)
plot(conso)

Modification of consumption makes it right

conso_true <- conso(dive, tank, cons = 25)
plot(conso_true)

@gowachin gowachin reopened this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant