This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Fix for cached wysiwyg embeds not displaying #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandaskii
dismissed
their stale review
The PR has failed testing reported by our tester
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SRowlands
I am just going to leave this one here, it fixes the issue with #38 but there could be a more efficient way to achieve it.
It's using static caching so shouldn't do anything expensive more than once per page and with full page caching turned on, it only gets called on the initial cache build for a given page, subsequent pages retain the JS.