Skip to content

Commit

Permalink
tweak(ci): run dependant jobs on_success instead of always so that th…
Browse files Browse the repository at this point in the history
…ey don't run if dependency job failed
  • Loading branch information
nihonium committed Nov 23, 2023
1 parent 3e793d3 commit c04ba4d
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ workflow:
.only_for_release:
rules:
- if: $CFX_RELEASE_BUILD == 'true'
when: always
when: on_success
- when: never

# helper for jobs that are only meant to be run on master branch
.only_for_master:
rules:
- if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'master'
when: always
when: on_success
- when: never

# helper for windows builds of clients and server
Expand Down Expand Up @@ -191,7 +191,7 @@ fivem_deploy_canary:
name: canary
rules:
- if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'master'
when: always
when: on_success
- when: never

fivem_deploy_beta:
Expand All @@ -200,7 +200,7 @@ fivem_deploy_beta:
name: beta
rules:
- if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'beta'
when: always
when: on_success
- when: never

fivem_deploy_production:
Expand All @@ -209,7 +209,7 @@ fivem_deploy_production:
name: production
rules:
- if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'production'
when: always
when: on_success
- when: never

fivem_deploy_specific:
Expand All @@ -229,7 +229,7 @@ redm_deploy_canary:
name: canary
rules:
- if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'master'
when: always
when: on_success
- when: never

redm_deploy_beta:
Expand All @@ -238,7 +238,7 @@ redm_deploy_beta:
name: beta
rules:
- if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'beta'
when: always
when: on_success
- when: never

redm_deploy_production:
Expand All @@ -247,7 +247,7 @@ redm_deploy_production:
name: production
rules:
- if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'production'
when: always
when: on_success
- when: never

redm_deploy_specific:
Expand Down

0 comments on commit c04ba4d

Please sign in to comment.