-
-
Notifications
You must be signed in to change notification settings - Fork 801
feat: Add push-message UI on Messages page with tests && feat: Add message list filtering and in-app push UI #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm sorry to hear that. after reviewing all the issues related to the search feature, it's clear from the comments and reactions that many people are interested in this functionality. (In this PR, I only implemented a UI filter feature, avoiding any intrusive backend complexity.) if someone is still interested in this filter function, here is the branch reference: https://github.com/AlliotTech/server/tree/feat/ui-search Anyway, I have already removed the search functionality from this PR. The current PR now only includes the push message feature. |
jmattheis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I've added some remarks in subcomments.
Co-authored-by: Jannis Mattheis <[email protected]>
Co-authored-by: Jannis Mattheis <[email protected]>
Co-authored-by: Jannis Mattheis <[email protected]>
… Messages component
|
Thank you, I've already fixed it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #897 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 56 56
Lines 2226 2226
=======================================
Hits 1762 1762
Misses 360 360
Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmattheis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Add a “Push Message” action and dialog on the Messages page
(only for app-specific views)
Send messages using the application token, avoiding
interceptor overwrite
Add UI tests covering button visibility and send flow
Add quick filters to the Messages page (search title/body
and exact priority)
Preview
Related issues
#276