codeblocks have syntax highlighting #1
Conversation
|
allowing style and class attributes seems like a pretty bad idea, we should probably be sanitizing it first, then parse it as shiki, no? |
JustTemmie
left a comment
JustTemmie
left a comment
There was a problem hiding this comment.
seem fine to me, waiting for a review from @SauceyRed too
| }); | ||
|
|
||
| doc = parser.parseFromString(sanitized.value, 'text/html'); | ||
| // how do you zip a list? |
There was a problem hiding this comment.
for (language, codeblock) in zip(languages, doc.queryselectorall('code'))
There was a problem hiding this comment.
What is the zip supposed to be doing?
There was a problem hiding this comment.
iterates both at the same time, i.e
let i = 0;
for i in 0..languages.len() {
let (language, codeblock) = (languages[i], codeblocks[i])
}| "pinia": "^3.0.2", | ||
| "pinia-plugin-persistedstate": "^4.2.0", | ||
| "shiki": "^3.8.1", | ||
| "tm-themes": "^1.10.7", |
There was a problem hiding this comment.
This doesn't seem to be used anywhere.
There was a problem hiding this comment.
it is, it provides the gruvbox
|
Another thing, there should be both inline and block code. Currently there's no difference. |
3 participants
seems to work