Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #72. Update URL, introduce error when ListenAndServe fail. #73

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

IAmAnubhavSaini
Copy link
Contributor

@IAmAnubhavSaini IAmAnubhavSaini commented Jan 17, 2024

  1. The URL where the server is running is updated so that it can be clicked from the terminal, in case the terminal supports it.
  2. The error is thrown if the port cannot be bound by the tutorial server.

Before:

python -m http.server 8000
Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ...
go run .
Serving Go+ tutorial at localhost:8000

After

go run .
Serving Go+ tutorial at http://localhost:8000
2024/01/17 11:28:37 Failed to start server at http://localhost:8000.
Error: listen tcp 127.0.0.1:8000: bind: address already in use.
exit status 1

1. The URL where the server is running is updated so that it can be
clicked from the terminal, in case the terminal supports it.
2. The error is thrown if the port cannot be bound by the tutorial
server.
@xushiwei xushiwei merged commit 37f0c49 into goplus:main Feb 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants