feat(coroutine): improve panic handling with igop-style stack traces #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When spx runs in an igop environment, we need to preserve the original stack info from panics to help with debugging. This change adds support for igop-style panic errors that carry stack info. Signed-off-by: Aofei Sheng <[email protected]>
xushiwei
reviewed
Feb 9, 2025
| @@ -80,7 +75,9 @@ func (p *Coroutines) CreateAndStart(start bool, tobj ThreadObj, fn func(me Threa | |||
| p.mutex.Unlock() | |||
| p.sema.Unlock() | |||
| if e := recover(); e != nil { | |||
| if e != ErrAbortThread { | |||
| if pe, ok := e.(iGopPanicError); ok { | |||
| panic(pe.Error() + "\n" + string(pe.Stack())) | |||
There was a problem hiding this comment.
why not to format error info in outer side (at where recover this error)?
There was a problem hiding this comment.
The issue isn't about formatting error info. When user code panics, the panic/recover mechanism here catches and re-throws it, which creates a new stack trace starting from the re-panic point. This makes it impossible to trace back to the original panic location in user code.
|
May be related to #494 |
|
This PR has been abandoned in favor of #495 since we don't want spx to be aware of igop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spx runs in an igop environment, we need to preserve the original stack info from panics to help with debugging. This change adds support for igop-style panic errors that carry stack info.