Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .xcodeproj back in the framework. #529

Conversation

iHackSubhodip
Copy link
Collaborator

@iHackSubhodip iHackSubhodip commented Feb 1, 2025

What's changing?

  • Add .xcodeproj back in the framework.
  • Add GoogleMaps.bundle in .xcodeproj copy bundle resources.
  • Add GMUGeometryRendererTest, which was causing the below issue.
  • Rename folder GoogleMapsUtilsSwiftTests to GoogleMapsUtilsTests

Why? (The issue)

  • Google Maps SDK for iOS requires GoogleMaps.bundle to be part of your target under 'Copy Bundle Resources' (GMSServicesException)
  • Root Cause: Currently, there is no .xcodeproj in the framework, and the GoogleMaps dependency is fetched from SPM, instead of xcodeproj's Copy Bundle Resources.
  • Attaching screenshot for more reference.
  • Reference PR: Link
Screenshot 2025-02-01 at 9 55 36 AM

Validation:

  • I did run the Unit tests, it's passing.
Screenshot 2025-02-01 at 9 57 51 AM

@iHackSubhodip iHackSubhodip changed the title chore: Add .xcodeproj back in the framework. chore: Add .xcodeproj back in the framework. Feb 1, 2025
@iHackSubhodip iHackSubhodip requested a review from wangela February 1, 2025 04:40
@iHackSubhodip iHackSubhodip merged commit 5438fc6 into feature/Cluster-QuadTree-Heatmap-Geometry-swift Feb 5, 2025
5 checks passed
@iHackSubhodip iHackSubhodip deleted the SB/add-xcode-in-framework branch February 5, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants