Fix OverflowErrors when pre-applying transform to radial gradient geometry #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
Mar 14, 2023
src/nanoemoji/paint.py
Outdated
| s = max(*scale.getscale()) | ||
| # we take the minimum of (sx, sy) to try to minimize the risk of OverflowErrors | ||
| # when encoding these to F16Dot16 | ||
| s = min(*scale.getscale()) |
There was a problem hiding this comment.
I immediately wonder if we should try both?
|
Capturing @anthrotype's idea from this morning, we should make test inputs with big upem to exacerbate the problem |
|
Thinking "aloud" I wonder if SVD on the transform would make it easier to assemble a stack of transforms that work ... e.g. SVD, then search for parts you can put back together to minimize the # of paints you end up with |
anthrotype
changed the title
…ise OverflowErrors" This reverts commit 7d341f5.
anthrotype
force-pushed
the
fix-radial-overflow-error
branch
from
7a73f25 to
7ec0f1b
Compare
anthrotype
force-pushed
the
fix-radial-overflow-error
branch
from
7ec0f1b to
10671af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, will add test soon