color_glyph: remove assertion that width > 0 #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's valid for fonts to have glyphs with zero advance width, e.g. combining marks
currently fails for bitmap format because of #404
anthrotype
force-pushed
the
remove-assert-width-0
branch
from
eab5423 to
063e41a
Compare
I think this was true but iirc should no longer be. In any case, definitely a bad assert, good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's valid for fonts to have glyphs with zero advance width, e.g. combining marks
I stumbled on this while running
maximum_coloron a yet-to-be-published color font project, after exporting from Glyphs.app as an OT-SVG.I wonder why the assertion was put that to begin with. Is it because when width is 0, a bitmap CBDT glyph would otherwise completely disappear (#402)?