colr_to_svg: test len(CPAL) > 1 uses var(--colors)

googlefonts · Sep 9, 2022 · aa55b5a · aa55b5a
1 parent fc20f7f
commit aa55b5a
Showing 1 changed file with 31 additions and 6 deletions.
diff --git a/tests/colr_to_svg_test.py b/tests/colr_to_svg_test.py
@@ -46,8 +46,14 @@ def _buildPaint(source) -> ot.Paint:
     return LayerListBuilder().buildPaint(source)
 
 
+# palette 0: black, blue
+SIMPLE_CPAL = [[(0, 0, 0, 1.0), (0, 0, 1, 1.0)]]
+# palette 1: red, green
+MULTI_CPAL = [SIMPLE_CPAL[0], [(1, 0, 0, 1), (0, 1, 0, 1)]]
+
+
 @pytest.mark.parametrize(
-    "glyph_to_convert, color_glyphs, monochrome_glyphs, expected_svg",
+    "glyph_to_convert, color_glyphs, monochrome_glyphs, palettes, expected_svg",
     [
         # Solid filled box
         (
@@ -60,6 +66,7 @@ def _buildPaint(source) -> ot.Paint:
                 ),
             },
             {"box": _draw_box},
+            SIMPLE_CPAL,
             """
             <svg xmlns="http://www.w3.org/2000/svg">
               <defs/>
@@ -79,6 +86,7 @@ def _buildPaint(source) -> ot.Paint:
                 ),
             },
             {"box": _draw_box},
+            SIMPLE_CPAL,
             """
             <svg xmlns="http://www.w3.org/2000/svg">
               <defs/>
@@ -121,6 +129,7 @@ def _buildPaint(source) -> ot.Paint:
                 },
             },
             {"box": _draw_box},
+            SIMPLE_CPAL,
             """
             <svg xmlns="http://www.w3.org/2000/svg">
               <defs/>
@@ -160,17 +169,37 @@ def _buildPaint(source) -> ot.Paint:
                 },
             },
             {"box": _draw_box},
+            SIMPLE_CPAL,
             """
             <svg xmlns="http://www.w3.org/2000/svg">
               <defs/>
               <path d="M10,10 L90,10 L90,90 L10,90 Z"/>
             </svg>
             """,
         ),
+        # len(CPAL.palettes) > 1, using var(--color{index})
+        (
+            "color_box",
+            {
+                "color_box": (
+                    ot.PaintFormat.PaintGlyph,
+                    (ot.PaintFormat.PaintSolid, 1),
+                    "box",
+                ),
+            },
+            {"box": _draw_box},
+            MULTI_CPAL,
+            """
+            <svg xmlns="http://www.w3.org/2000/svg">
+              <defs/>
+              <path fill="var(--color1, blue)" d="M10,10 L90,10 L90,90 L10,90 Z"/>
+            </svg>
+            """,
+        ),
     ],
 )
 def test_colr_v1_paint_to_svg(
-    glyph_to_convert, color_glyphs, monochrome_glyphs, expected_svg
+    glyph_to_convert, color_glyphs, monochrome_glyphs, palettes, expected_svg
 ):
     actual_svg = SVG.fromstring('<svg xmlns="http://www.w3.org/2000/svg"><defs/></svg>')
     expected_svg = SVG.fromstring(textwrap.dedent(expected_svg))
@@ -203,10 +232,6 @@ def test_colr_v1_paint_to_svg(
 
     print(hmtx_table.metrics)
 
-    # palette 0: black, blue
-    palettes = [
-        [(0, 0, 0, 1.0), (0, 0, 1, 1.0)],
-    ]
     font["CPAL"] = buildCPAL(palettes)
 
     layers, base_glyphs = buildColrV1(color_glyphs)