test unindexed colors don't get mixed with indexed ones with same RGBA

googlefonts · Sep 14, 2022 · 13c56c8 · 13c56c8
1 parent de440d3
commit 13c56c8
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/tests/colors_test.py b/tests/colors_test.py
@@ -143,6 +143,20 @@ def test_color_like_namedtuple():
             ],
             id="fill-empty-slots",
         ),
+        # unindexed color are never conflated with those with an explicit index
+        # even if == RGBA value, for selecting a different palette should not
+        # inadvertently affect colors that weren't explicitly assigned an index
+        pytest.param(
+            [
+                Color(0xFF, 0, 0, 1.0),
+                Color(0xFF, 0, 0, 1.0, palette_index=0),
+            ],
+            [
+                Color(0xFF, 0, 0, 1.0, palette_index=0),
+                Color(0xFF, 0, 0, 1.0),
+            ],
+            id="keep-unindexed-distinct",
+        ),
     ],
 )
 def test_uniq_sort_cpal_colors(colors, expected):

diff --git a/tests/cpal_color_indices.svg b/tests/cpal_color_indices.svg
diff --git a/tests/write_font_test.py b/tests/write_font_test.py
@@ -645,5 +645,6 @@ def test_colr_keep_cpal_palette_entry_indices():
         "#FF0000FF",  # red was var(--color0)
         "#00FF00FF",  # 'lime' had no var(--color), implicitly placed in empty slot
         "#0000FFFF",  # blue was var(--color2)
+        "#FF0000FF",  # same as #0 but no explicit index; placed in unindexed slot
         "#FFFFFFFF",  # white had no var(--color), no empty slots, appended at the end
     ]