Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move JS code from HTML to start.js #1984

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Move JS code from HTML to start.js #1984

merged 1 commit into from
Jan 24, 2025

Conversation

simoncozens
Copy link
Contributor

This is another PR aimed at reducing the size of the #1952 change when it comes. It's good to have all the JS things in JS, not in HTML!

@simoncozens simoncozens mentioned this pull request Jan 23, 2025
Open
11 tasks
justvanrossum
justvanrossum approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Ideally, I think only the theme-settings imports should stay in the start.js files. I'll see what I can clean up after this.

@justvanrossum justvanrossum merged commit 939f6dc into main Jan 24, 2025
5 checks passed
@justvanrossum justvanrossum deleted the start.js branch January 24, 2025 08:04
@justvanrossum justvanrossum mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justvanrossum justvanrossum justvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simoncozens @justvanrossum