Move findParentWithClass to ui-utils.js #1866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justvanrossum
approved these changes
Dec 17, 2024
|
On the other hand, this function seems to only be used to find some internal container for the Accordion view. Maybe it is better to add a method to the
Then we have this functionality nicely abstracted where it belongs. |
ollimeier
force-pushed
the
issue-1865-refactor-findParentWithClass
branch
from
60fbfbf to
0c41855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1865
In preparation for #102, because
findParentWithClassis also needed for the font overview when using theGlyphCell.