Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a simple cmap #134

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Build a simple cmap #134

merged 7 commits into from
Mar 15, 2023

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Mar 12, 2023

Add a job to generate cmap and wire it through to work in simple cases. Demonstrate it produces the expected glyph order and unicode assignments.

Contributes to #138.

Requires googlefonts/fontations#275.

@rsheeter rsheeter changed the base branch from main to composite_glyphs March 12, 2023 21:11
@rsheeter rsheeter force-pushed the cmap1 branch 2 times, most recently from 57c25c4 to f8ebbc7 Compare March 13, 2023 05:01
@rsheeter rsheeter changed the title [WIP] Build a simple cmap Build a simple cmap Mar 13, 2023
@rsheeter rsheeter marked this pull request as ready for review March 13, 2023 05:09
@rsheeter
Copy link
Contributor Author

rsheeter commented Mar 13, 2023

Per f2f discussion make a high level API on write-fonts and pass something akin to a map codepoint:gid in. Ref https://github.com/googlefonts/ufo2ft/blob/5b22f201b4650ab9ef1169357702a732e3127a5e/Lib/ufo2ft/outlineCompiler.py#L460-L542 .

Edit: this is now done

Base automatically changed from composite_glyphs to main March 13, 2023 19:09
@rsheeter rsheeter mentioned this pull request Mar 14, 2023
@rsheeter rsheeter merged commit d43e779 into main Mar 15, 2023
@rsheeter rsheeter deleted the cmap1 branch March 15, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants