Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: checking the Java formatter test #3672

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Mar 3, 2025

Does the Java formatter really run?
Looking at https://github.com/googleapis/java-shared-config/blob/f4daddb30447165f73e2b5d8bcb8436c684cf5fb/java-shared-config/pom.xml#L172,
it only be configured as pluginManagement and it doesn't seem to
be configured run in CI builds.

Does the Java formatter really run?
Looking at https://github.com/googleapis/java-shared-config/blob/f4daddb30447165f73e2b5d8bcb8436c684cf5fb/java-shared-config/pom.xml#L172,
it only be configured as pluginManagement and it doesn't seem to
be configured run in CI builds.
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 3, 2025
@suztomo
Copy link
Member Author

suztomo commented Mar 3, 2025

It failed at "ci / lint":

[INFO] --- fmt:2.9:check (default-cli) @ google-cloud-core ---
[INFO] Processed 81 files (1 non-complying).
Error:  Found 1 non-complying files, failing build
Error:  To fix formatting errors, run "mvn com.coveo:fmt-maven-plugin:format"
Error:  Non complying file: /home/runner/work/sdk-platform-java/sdk-platform-java/java-core/google-cloud-core/src/main/java/com/google/cloud/Service.java

@suztomo
Copy link
Member Author

suztomo commented Mar 3, 2025

The lint check already uses Java 11. https://github.com/googleapis/sdk-platform-java/actions/runs/13639131969/workflow?pr=3672#L199

Picking up a handwritten library java-storage, it also uses Java 11 for the lint job https://github.com/googleapis/java-storage/actions/runs/13636614376/workflow?pr=2970#L107 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant