-
Notifications
You must be signed in to change notification settings - Fork 17
tests: update default python runtime for tests to 3.14 #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the default Python version used for testing and linting within the Nox configuration. The change ensures that these automated processes leverage a more recent Python runtime, specifically targeting version 3.14, and standardizes the Python version used across relevant Nox sessions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the default Python version to 3.14 for various nox sessions. The changes correctly update the DEFAULT_PYTHON_VERSION constant and refactor the lint and lint_setup_py sessions to use this constant, which is a good improvement for maintainability. The changes look good, and I have one suggestion to improve consistency even further.
| BLACK_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"] | ||
|
|
||
| DEFAULT_PYTHON_VERSION = "3.8" | ||
| DEFAULT_PYTHON_VERSION = "3.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is blocked on googleapis/sphinx-docfx-yaml#345.
Add comment in 6970ade
Similar to googleapis/python-api-core#870