fix: honor custom retry
in job.result()
#2302
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_AsyncJob.result()
method was not correctly passing the right arguments to the superclass'sresult()
method when theretry
object was expected to be the same as theDEFAULT_RETRY
object. Passing an emptydict
was a way of simply letting thegoogle.api_core
handle things.When the
retry
object is instantiated and when theDEFAULT_RETRY
object is instantiated, these two elements are separate objects. This means that because theis
keyword checks for identity NOT equality that code path never evaluates toTrue
and is not used as one would expect.This leads to subtle bugs that this PR corrects by simply passing the
retry
object and relying on thegoogle.api_core
to understand what aDEFAULT_RETRY
value is and managing it appropriately.A new test case is added to verify that
job.result()
correctly handles both the default retry use case and a custom retry object use case.Fixes #2210 🦕