test: fix BackgroundConsumer error log#814
Merged
daniel-sanche merged 6 commits intomainfrom Apr 10, 2025
Merged
Conversation
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: s
vchudnov-g
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We #770 that clears some variables that were causing a memory leak in the bidirectional streaming classes. This change lead to a potential null pointer exception during the shut-down process when the BackgroundConsumer tries to access the removed callback.
The issue would only come up when the background thread failed to finalize within 1 second, and the error would be swallowed internally. But it would result in an error log that should be avoided
This PR does a None check to avoid emitting the error log
Fixes #788