Skip to content

fix: Fix deepcopy for RubricGenerationConfig in RubricBasedMetric. #5783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

fix: Fix deepcopy for RubricGenerationConfig in RubricBasedMetric. #5783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion vertexai/preview/evaluation/_evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,6 +1019,24 @@ def _get_rubric_metric_with_idx(
return None


def _safe_deepcopy_rubric_generation_config(
generation_config: metrics_base.RubricGenerationConfig,
) -> metrics_base.RubricGenerationConfig:
"""Safely deepcopies the rubric generation config of RubricBasedMetric."""
copied_generation_config = None

if generation_config:
generation_config_model = generation_config.model
# Cannot deepcopy instance of GenerativeModel due to its cygrpc.Channel
generation_config.model = None
copied_generation_config = copy.deepcopy(generation_config)

if generation_config_model:
copied_generation_config.model = generation_config_model

return copied_generation_config


def evaluate(
dataset: "pd.DataFrame",
metrics: List[Union[str, metrics_base._Metric]],
Expand Down Expand Up @@ -1095,7 +1113,9 @@ def evaluate(
elif isinstance(metric, rubric_based_metric.RubricBasedMetric):
copied_metrics.append(
rubric_based_metric.RubricBasedMetric(
generation_config=copy.deepcopy(metric.generation_config),
generation_config=_safe_deepcopy_rubric_generation_config(
metric.generation_config,
),
critique_metric=copy.deepcopy(metric.critique_metric),
)
)
Expand Down