-
Notifications
You must be signed in to change notification settings - Fork 136
feat: add SsFormat encoding library #4292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @rahul2393, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces core encoding utilities for Spanner's key management and routing. It provides a robust Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the SsFormat encoding library and the TargetRange class, which are foundational for sortable string format (ssformat) encoding utilities used by Spanner for key ordering and routing. The SsFormat class provides various encoding methods for different data types, including integers, strings, doubles, timestamps, and UUIDs, supporting both increasing and decreasing order. The TargetRange class represents a key range and includes logic for merging ranges. Overall, it is a good starting point. However, I've identified a potential correctness issue in the byte sequence encoding and some areas for improved maintainability.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SsFormat.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SsFormat.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/TargetRange.java
Show resolved
Hide resolved
fcdf2cc to
5ad36f7
Compare
| decreasing | ||
| ? ASCENDING_ZERO_ESCAPE | ||
| : ASCENDING_ZERO_ESCAPE); // After inversion, 0xFF becomes 0x00. Escape for 0x00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems weird. Regardless of the value of decreasing, the same byte is written. Can this ternary operation be removed? If not, can we have a test that would have caught this?
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SsFormat.java
Outdated
Show resolved
Hide resolved
| private SsFormat() {} | ||
|
|
||
| private static final int IS_KEY = 0x80; | ||
| private static final int TYPE_MASK = 0x7f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be unused. Can it be removed?
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SsFormat.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SsFormat.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SsFormat.java
Outdated
Show resolved
Hide resolved
| private static final byte SEP = (byte) 0x78; // 'x' | ||
|
|
||
| // For AppendCompositeTag | ||
| private static final int K_OBJECT_EXISTENCE_TAG = 0x7e; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This constant appears only to be used in the check at the start of appendCompositeTag, but otherwise unused (including in tests). Can it be removed? If not, can we add tests that use it?
| appendByteSequence(out, value, false); | ||
| } | ||
|
|
||
| public static void appendBytesDecreasing(ByteArrayOutputStream out, byte[] value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears unused (including by tests). Can we remove it, or add tests for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - it's needed for completeness. The KeyRecipe PR will need it for BYTES columns with DESC order. Removing it now would just mean adding it back later
The same applies to other "unused" methods like appendStringDecreasing, appendIntDecreasing, appendDoubleDecreasing - they're all needed when recipes specify DESC order for those column types.
For now I added the tests for it
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SsFormat.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SsFormat.java
Show resolved
Hide resolved
22555e7 to
d279fef
Compare
d279fef to
258c049
Compare
258c049 to
72f2d82
Compare
This commit adds the foundational SsFormat class that provides sortable string format (ssformat) encoding utilities. This encoding is used by Spanner for key ordering and routing.
Key features:
This is part of the experimental location-aware routing for improved latency.