Skip to content

Revert "chore: Temporarily disable tests due to Quota Issues" #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Revert "chore: Temporarily disable tests due to Quota Issues" #1700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e92723
Revert "chore: Temporarily disable tests due to Quota Issues (#1699)"
lqiu96 Oct 1, 2024
e383f9d
Merge branch 'main' into revert-1699-temp-ignore-test
cindy-peng Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions google-cloud-logging/src/test/java/com/google/cloud/logging/it/ITJulLoggerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import java.util.logging.Level;
import java.util.logging.Logger;
import org.junit.After;
import org.junit.Ignore;
import org.junit.Test;

public class ITJulLoggerTest extends BaseSystemTest {
Expand All @@ -50,7 +49,6 @@ public void tearDown() throws InterruptedException {
assertTrue(cleanupLog(LOG_ID));
}

@Ignore
@Test
public void testLoggingHandler() throws InterruptedException {
LoggingOptions options = logging.getOptions();
Expand Down Expand Up @@ -87,7 +85,6 @@ public void testLoggingHandler() throws InterruptedException {
logger.removeHandler(handler);
}

@Ignore
@Test
public void testSyncLoggingHandler() throws InterruptedException {
LoggingOptions options = logging.getOptions();
Expand Down
4 changes: 0 additions & 4 deletions google-cloud-logging/src/test/java/com/google/cloud/logging/it/ITLoggingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import java.util.Iterator;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test;

public class ITLoggingTest extends BaseSystemTest {
Expand Down Expand Up @@ -83,7 +82,6 @@ public static void cleanUpLogs() throws InterruptedException {
assertTrue(cleanupLog(LOG_ID));
}

@Ignore
@Test(timeout = 600_000) // Note: it can take ~10 minutes for logs to propagate!
public void testListEntries() throws InterruptedException {
LoggingOptions loggingOptions = logging.getOptions();
Expand Down Expand Up @@ -117,7 +115,6 @@ public void testListEntries() throws InterruptedException {
assertNotNull(entry.getTimestamp());
}

@Ignore
@Test(timeout = 600_000) // Note: it can take ~10 minutes for logs to propagate!
public void testSortedOrder() throws InterruptedException {
LoggingOptions loggingOptions = logging.getOptions();
Expand All @@ -141,7 +138,6 @@ public void testSortedOrder() throws InterruptedException {
}
}

@Ignore
@Test
public void testDeleteNonExistingLog() {
String logId = formatForTest("test-delete-non-existing-log");
Expand Down
2 changes: 0 additions & 2 deletions google-cloud-logging/src/test/java/com/google/cloud/logging/it/ITTracingLogsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,8 @@
import java.util.Iterator;
import org.junit.After;
import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test;

@Ignore
public class ITTracingLogsTest extends BaseSystemTest {

private static final String LOG_ID = formatForTest("test-write-log-entries-log");
Expand Down
Loading