Skip to content

ci: make it easy to change the dependencies via "mvn version:set-property" #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suztomo wants to merge 8 commits into
base: main
Choose a base branch
from
Open

ci: make it easy to change the dependencies via "mvn version:set-property" #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ebe5292
ci: extract_properties
suztomo Nov 19, 2025
8280938
Leverage .mvn/maven.config
suztomo Nov 19, 2025
f511c29
revert .kokoro/common.sh
suztomo Nov 19, 2025
8d10007
sdk-platform-config version
suztomo Nov 19, 2025
bc48161
3.54.0
suztomo Nov 19, 2025
f79ec92
fix pom
suztomo Nov 19, 2025
abc5de4
remove maven.config for now
suztomo Nov 19, 2025
e64f613
Adding gax in the path too
suztomo Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .kokoro/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ source ${scriptDir}/common.sh
mvn -version
echo ${JOB_TYPE}

echo "mvn dependency:tree for google-cloud-logging and gax"
mvn dependency:tree -Dverbose -Dincludes=com.google.cloud:google-cloud-logging,com.google.api:gax

echo "mvn help:effective-pom"
mvn help:effective-pom -Dverbose

echo "Installing the project"

Comment on lines +30 to +37
Copy link
Member

@meltsufin meltsufin Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member Author

@suztomo suztomo Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, while it's not strictly needed, the commands are here to confirm the effect of dependency changes.

# attempt to install 3 times with exponential backoff (starting with 10 seconds)
retry_with_backoff 3 10 \
mvn install -B -V -ntp \
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<logback.version>1.2.13</logback.version>
<easymock.version>5.6.0</easymock.version>
<truth.version>1.4.4</truth.version>
<logging.version>3.23.8</logging.version>
<google-cloud-logging.version>3.23.8</google-cloud-logging.version>
<slf4j.version>1.7.36</slf4j.version>
<google.api-common.version>1.10.1</google.api-common.version>
</properties>
Expand Down Expand Up @@ -85,7 +85,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-logging</artifactId>
<version>${logging.version}</version>
<version>${google-cloud-logging.version}</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
Expand Down
Loading