Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Add more explanation and examples for logbackBatchingSettings #1436

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Doc: Add more explanation and examples for logbackBatchingSettings #1436

wants to merge 4 commits into from

Conversation

cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1403 ☕️

If you write sample code, please follow the samples format.

@cindy-peng cindy-peng requested review from a team as code owners February 11, 2025 06:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/java-logging-logback API. labels Feb 11, 2025
@cindy-peng
Copy link
Contributor Author

cindy-peng commented Feb 11, 2025 •
edited
Loading

Updated Readme preview:
image

@cindy-peng cindy-peng requested a review from blakeli0 February 11, 2025 06:26
bhshkh
bhshkh reviewed Feb 14, 2025
View reviewed changes
bhshkh
bhshkh reviewed Feb 14, 2025
View reviewed changes
bhshkh
bhshkh reviewed Feb 14, 2025
View reviewed changes
bhshkh
bhshkh reviewed Feb 14, 2025
View reviewed changes
bhshkh
bhshkh reviewed Feb 14, 2025
View reviewed changes
@bhshkh
Copy link

bhshkh commented Feb 14, 2025

Couple of nits. Overall LGTM

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhshkh bhshkh bhshkh approved these changes

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche daniel-sanche is a code owner automatically assigned from googleapis/api-logging

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/java-logging-logback API. size: s Pull request size is small. stale: old Pull request is old and needs attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more explanation and examples for logbackBatchingSettings
2 participants
@cindy-peng @bhshkh