Skip to content

feat: Add support for new Firestore types #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented May 1, 2025

Adds support for MinKey, MaxKey, RegexValue, Int32Value, BsonObjectId, BsonTimestamp, and BsonBinaryData.

* feat: type definition for six types.

* formatting and add some encoding logic.

* Add class mapper and data converter logic.

* Add Int32Value class.

* Add ordering logic.

* Add unit tests for encoding, decoding, and ordering.

* Add roundtrip (write and read back) integration tests.

* More integration tests with filter and ordering.

* fix: use a valid Bson ObjectId.

* Address feedback 1.

* Address feedback 2.

* Address feedback 3.

* Fix the parameter ordering for BsonBinaryData.
@ehsannas ehsannas self-assigned this May 1, 2025
@ehsannas ehsannas requested a review from a team as a code owner May 1, 2025 21:00
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/java-firestore API. labels May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants