Conversation
product-auto-label
bot
added
size: l
| return channelPoolMetricsTracer; | ||
| } | ||
|
|
||
| @Nullable |
Contributor
There was a problem hiding this comment.
dont make this nullable, instead add a NoopTracer in NoopMetrics
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.cloud.bigtable.data.v2.stub; |
Contributor
There was a problem hiding this comment.
If this is unary/jetstream agnostic, then it should live in data.v2.internal...maybe create a pacakge for dp?
Comment on lines
+643
to
+644
| .setDirectAccessRequested(true) | ||
| .setTrafficDirectorEnabled(true) |
Contributor
There was a problem hiding this comment.
why you ignoring the env var?
| * inspecting the response headers. | ||
| */ | ||
| @InternalApi | ||
| public class UnaryDirectAccessChecker implements DirectAccessChecker { |
Comment on lines
+23
to
+24
| public interface BigtableChannelFactory { | ||
| ManagedChannel createSingleChannel() throws IOException; |
Contributor
There was a problem hiding this comment.
why not use Supplier
|
|
||
| @Override | ||
| public boolean check( | ||
| BigtableChannelFactory channelFactory, @Nullable DirectPathCompatibleTracer tracer) { |
Contributor
There was a problem hiding this comment.
move these to the ctor
Contributor
There was a problem hiding this comment.
as above, please make the tracer non-null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.