Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Dec 17, 2025

Reverts #14972

@parthea parthea requested review from a team as code owners December 17, 2025 15:50
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 17, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a configuration adjustment by reverting a previous change that had temporarily halted the generation process for a substantial collection of client libraries. The intention behind this revert is to facilitate a phased and gradual rollout strategy, allowing for better management and deployment of these libraries.

Highlights

  • Revert of Blocked Generation: This pull request reverts a previous change that temporarily blocked code generation for a large number of client libraries within the .librarian/config.yaml file.
  • Facilitating Gradual Rollout: The primary purpose of this revert is to unblock these libraries, enabling a more controlled and gradual rollout of changes or updates.
  • Configuration Update: The generate_blocked: true flag has been removed from numerous library entries in the Librarian configuration, effectively reactivating their generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change, unblocking code generation for a large number of libraries by removing their entries from the .librarian/config.yaml file. This change is consistent with the stated goal of facilitating a gradual rollout. The modifications are straightforward, and I have not identified any issues in this revert.

@parthea
Copy link
Contributor Author

parthea commented Dec 17, 2025

Please do not merge this PR until after tomorrow's release as the purpose of #14972 was to only generate/release a subset of libraries with gapic-generator-python 1.30.2.

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 17, 2025
@parthea parthea merged commit 43f2b80 into main Dec 17, 2025
26 checks passed
@parthea parthea deleted the revert-14972-gradual-rollout-gapic-update-2025-12-16 branch December 17, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants