Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Dec 16, 2025

This PR fixes a bug introduced in #14901 which adds the following text to all generated files. We only want this text added to .librarian/generator-input

# DO NOT EDIT THIS FILE OUTSIDE OF `.librarian/generator-input`
# The source of truth for this file is `.librarian/generator-input`

@parthea parthea requested review from a team as code owners December 16, 2025 18:43
@gemini-code-assist
Copy link

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug introduced in a previous change that caused a specific 'DO NOT EDIT' header to be erroneously applied to all generated files. The fix refines the file processing workflow to ensure that this header is now correctly and exclusively added to files residing in the .librarian/generator-input directory, aligning with the intended behavior and preventing unintended modifications to other generated outputs.

Highlights

  • Bug Fix: Corrected an issue where a 'DO NOT EDIT' header was being added to all generated files, instead of exclusively to files within the .librarian/generator-input directory.
  • File Processing Logic: Implemented a temporary directory approach during file copying to isolate the header application process, ensuring the header is only applied to the intended files before they are moved to their final destination.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where a header was incorrectly added to all generated files. The proposed solution correctly isolates the intended files within a temporary directory, applies the header, and then moves them to the final destination. This approach is clean, effective, and resolves the issue described. The change is well-implemented and improves the generator's behavior.

@parthea parthea merged commit 3ab691f into main Dec 16, 2025
25 checks passed
@parthea parthea deleted the only-add-header-to-generator-input branch December 16, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants