Skip to content

chore(librarian): Create package changelog if not present #14963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 1 commit into from
Dec 12, 2025
Merged

chore(librarian): Create package changelog if not present #14963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .generator/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,12 @@ def handle_configure(
)
prepared_config = _prepare_new_library_config(new_library_config)

# Create a `CHANGELOG.md` and `docs/CHANGELOG.md` file for the new library
is_mono_repo = _is_mono_repo(input)
library_id = _get_library_id(prepared_config)
_create_new_changelog_for_library(library_id, output)
path_to_library = f"packages/{library_id}" if is_mono_repo else "."
if not Path(f"{repo}/{path_to_library}").exists():
Comment on lines +295 to +296
Copy link

@gemini-code-assist gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability and cross-platform compatibility, it's better to use pathlib's / operator for joining path components rather than f-string formatting. This is the idiomatic way to work with pathlib and avoids potential issues with path separators.

Suggested change
path_to_library = f"packages/{library_id}" if is_mono_repo else "."
if not Path(f"{repo}/{path_to_library}").exists():
path_to_library_str = f"packages/{library_id}" if is_mono_repo else "."
if not (Path(repo) / path_to_library_str).exists():

# Create a `CHANGELOG.md` and `docs/CHANGELOG.md` file for the new library
_create_new_changelog_for_library(library_id, output)

# Write the new library configuration to configure-response.json.
_write_json_file(f"{librarian}/configure-response.json", prepared_config)
Expand Down
Loading