chore(storage): remove form-data dependency use native globals and update package scripts - #9120
Open
thiyaguk09 wants to merge 5 commits into
Open
chore(storage): remove form-data dependency use native globals and update package scripts#9120thiyaguk09 wants to merge 5 commits into
thiyaguk09 wants to merge 5 commits into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the 'samples-test' script, cleans up unused dependencies ('form-data' and 'cross-env'), and simplifies the 'test' script. Feedback suggests replacing the 'samples-test' script with a no-op command instead of deleting it to avoid breaking CI pipelines that might still invoke it. Additionally, it is recommended to restore the 'cross-env' and preload configuration in the 'test' script, as removing them appears unrelated to the dependency cleanup.
thiyaguk09
changed the title
thiyaguk09
marked this pull request as ready for review
August 11, 2026 09:15
thiyaguk09
force-pushed
the
fix/7348-form-data-vulnerability
branch
2 times, most recently
from
August 13, 2026 08:07
ad286ae to
666d700
Compare
…pes/request dependency
thiyaguk09
force-pushed
the
fix/7348-form-data-vulnerability
branch
from
August 14, 2026 07:40
666d700 to
033de68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
form-datadependency (and related legacy HTTP packages) in@google-cloud/storageby adopting native Node.js 18+ global APIs and resolving transitive vulnerability paths.Key Changes
form-dataandnode-fetchimports in tests with built-in globalFormDataandfetch.form-data,node-fetch,@types/node-fetch, and@types/requestfromdevDependencies.retry-requestto^8.0.0andteeny-requestto^10.0.0to eliminate transitiveform-datadependencies.samples-testscript and simplified test execution.Fixes #7348